mikewalch commented on issue #746: Make use of JAVA_TOOL_OPTIONS in accumulo-env.sh URL: https://github.com/apache/accumulo/issues/746#issuecomment-435996284 In `accumulo-env.sh`, we build `JAVA_OPTS` but allow users pass in extra options using `ACCUMULO_JAVA_OPTS`: ```bash ## JVM options set for all processes. Extra options can be passed in by setting ACCUMULO_JAVA_OPTS to an array of options. JAVA_OPTS=("${ACCUMULO_JAVA_OPTS[@]}" '-XX:+UseConcMarkSweepGC' '-XX:CMSInitiatingOccupancyFraction=75' '-XX:+CMSClassUnloadingEnabled' '-XX:OnOutOfMemoryError=kill -9 %p' '-XX:-OmitStackTraceInFastThrow' '-Djava.net.preferIPv4Stack=true' "-Daccumulo.native.lib.path=${lib}/native") ``` In `bin/accumulo`, we exec java with `JAVA_OPTS`: ```bash exec "${JAVA[@]}" "${JAVA_OPTS[@]}" org.apache.accumulo.start.Main "$@" ``` If we switch to `JAVA_TOOL_OPTIONS`, it sounds like we shouldn't exec java with `JAVA_TOOL_OPTIONS` as the JVM will include this environmental variable on its command line. However, are we sure this env variable is used by every JDK?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
