ctubbsii commented on issue #746: Make use of JAVA_TOOL_OPTIONS in accumulo-env.sh URL: https://github.com/apache/accumulo/issues/746#issuecomment-436023312 > In accumulo-env.sh, we build JAVA_OPTS but allow users pass in extra options using ACCUMULO_JAVA_OPTS Yeah, we should stop using `ACCUMULO_JAVA_OPTS` here. We don't need it. We should just append to whatever pre-existing value of `JAVA_TOOL_OPTIONS` is there, just like we should be doing for `CLASSPATH`, although it looks like that got dropped somehow since 1.9 and should be fixed. > If we switch to JAVA_TOOL_OPTIONS, it sounds like we shouldn't exec java with JAVA_TOOL_OPTIONS as the JVM will include this environmental variable on its command line. Correct. > However, are we sure this env variable is used by every JDK? It's not a guarantee, but as far as I can tell, it is an established standard used by Oracle, OpenJDK, and IBM, at the very least. It was established specifically for this purpose... so I think we should base our scripts on this standard. If a JVM doesn't abide by this standard, then it may be the case that the user might have to do completely different (non-standard) things to the scripts to get things working anyway... but we shouldn't code to that. We should code to the standard.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
