ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436074631 > I have mixed feelings about `from(Path)` vs `from(String)` because I think 99% of code will be `from(Paths.get(filePath))`. Yeah, I have mixed feelings, too. But, I still think less String is better. Some boilerplate is reasonable, when it helps clearly communicate the required type, and gives users more direct control over the behavior (with a String, they have no idea how we'll convert it to a path, normalize it, etc., but with Paths.get(), that behavior is predictable). In this case, that boilerplate also would only be called at the initialization of the client object, which 1) shouldn't be called as often as, say, mutation.put(), so the boilerplate will have minimal impact, and 2) this is when we're taking user input and reading from the file system and initializing stuff... things where we should be careful about ensuring we're explicitly getting what the user intends.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
