joshelser commented on a change in pull request #868: Make replication services
start when configured
URL: https://github.com/apache/accumulo/pull/868#discussion_r245380223
##########
File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
##########
@@ -1427,9 +1405,13 @@ public void run() {
final long deadline = System.currentTimeMillis() + MAX_CLEANUP_WAIT_TIME;
statusThread.join(remaining(deadline));
- replicationWorkAssigner.join(remaining(deadline));
- replicationWorkDriver.join(remaining(deadline));
- replAddress.server.stop();
+ if (!getConfiguration().get(Property.REPLICATION_NAME).isEmpty()) {
Review comment:
Nope, I'm just saying to always check if we have replication service threads
to stop, regardless of whether or not `Property.REPLICATION_NAME` is set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
