milleruntime commented on a change in pull request #870: Remove unused code in
master and server
URL: https://github.com/apache/accumulo/pull/870#discussion_r245418203
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/replication/DistributedWorkQueueWorkAssigner.java
##########
@@ -67,45 +67,18 @@ protected boolean isWorkRequired(Status status) {
protected int maxQueueSize;
protected ZooCache zooCache;
- /*
- * Getters/setters for testing purposes
- */
- protected AccumuloClient getClient() {
- return client;
- }
-
protected void setClient(AccumuloClient client) {
Review comment:
The two child classes have constructors that take `(AccumuloConfiguration
conf, AccumuloClient client)`. This method is only used for tests so we
probably just need to rewrite the tests to use the children. I can open a
follow on ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
