mikewalch commented on a change in pull request #52: Update checkstyle to use
import-control for API checking
URL: https://github.com/apache/accumulo-testing/pull/52#discussion_r251924621
##########
File path: contrib/checkstyle.xml
##########
@@ -17,12 +17,16 @@
<module name="Checker">
<property name="charset" value="UTF-8"/>
<module name="TreeWalker">
+ <!--check that only Accumulo public APIs are imported-->
+ <module name="ImportControl">
+ <property name="file" value="contrib/import-control.xml"/>
+ </module>
+ <!-- the following module was for accumulo 1.9
<module name="RegexpSinglelineJava">
- <!--check that only Accumulo public APIs are imported-->
- <property name="format"
value="import\s+org\.apache\.accumulo\.(.*\.(impl|thrift|crypto)\..*|(?!core|minicluster|testing).*|core\.(?!client|data|security).*)"/>
+ <property name="format"
value="import\s+org\.apache\.accumulo\.(.*\.(impl|thrift|crypto)\..*|(?!core|minicluster|testing|hadoop).*|core\.(?!client|data|security|iterators).*)"/>
Review comment:
This should probably just be removed as we only support 2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
