keith-turner commented on a change in pull request #1018: Fix #976 - Expand
overly broad Exceptions in Accumulo-core
URL: https://github.com/apache/accumulo/pull/1018#discussion_r271513008
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -286,7 +286,7 @@ public void process(WatchedEvent event) {
else if (asyncLock != null)
failedToAcquireLock();
}
- } catch (Throwable e) {
+ } catch (KeeperException | InterruptedException e) {
Review comment:
This code does more than log, it calls
`lockWatcher.unableToMonitorLockNode(e)` letting an observer know that the
state of the lock is now unknown. With ZK lock issues we do want to make a the
best possible effort to halt the process, even if we fail trying. It may make
sense to catch Throwable in case, I don't know without further inspection of
the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
