ctubbsii commented on issue #723: Use of Object.finalize() is deprecated in 
Java 9, and generally bad practice
URL: https://github.com/apache/accumulo/issues/723#issuecomment-500690922
 
 
   > ...if object already has Closable or analog of close implementation like 
MetaDataTableScanner it is looks simple to rely just on close call.
   
   Yes, but we'd need to ensure callers are calling the `close()` method in a 
try-with-resources block or in a finally block.
   
   Other options might be to use Java's new Cleaner utility (with 
PhantomReferences?), whose API I'm not yet familiar with using.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to