milleruntime commented on a change in pull request #1197: WIP - Added a catch
all for older CLI properties.
URL: https://github.com/apache/accumulo/pull/1197#discussion_r292967524
##########
File path: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
##########
@@ -82,6 +82,16 @@ public ColumnVisibility convert(String value) {
}
}
+ /**
+ * A catch all for older legacy options that have been dropped. Most of
them were replaced with
+ * accumulo-client.properties in 2.0. Others have been dropped completely.
+ */
+ @Parameter(names = {"-p", "-tc", "--tokenClass", "-i", "--instance",
"--debug", "-fake",
+ "--mock", "--site-file", "--keytab", "--ssl", "--sasl"},
+ description = "Legacy options that have been dropped. Use
accumulo-client.properties for" +
+ "any connection or token options. See '-c, --config-file'
option.")
+ private String legacyOpts = null;
Review comment:
I "think" we can get most of the commands with this class. I was thinking
throw and error with some useful breadcrumbs if the user tried to use a legacy
option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
