keith-turner commented on a change in pull request #1196: Update Accumulo to
build and run with Java 11
URL: https://github.com/apache/accumulo/pull/1196#discussion_r293002436
##########
File path: core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java
##########
@@ -220,7 +222,7 @@ public Builder addPlan(LoadPlan plan) {
@Override
public LoadPlan build() {
- return new LoadPlan(fmb.build());
+ return new LoadPlan(Collections.unmodifiableList(fmb));
Review comment:
This behaviors differs because user could still call addPlan after calling
build and mutate the list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
