keith-turner commented on issue #1281: Update TabletTime.maxMetadataTime(..) to 
use MetadataTime objects instead of string
URL: https://github.com/apache/accumulo/issues/1281#issuecomment-516413290
 
 
   > This update is fairly small and straightforward.
   
   For `maxMetadataTime(MetadataTime mv1, MetadataTime mv2)` would it make 
sense to throw an exception if the time types are not the same?  I am not sure 
how this method is used.  If the time types are expected to be the same (this 
would be the case it ifs only used to compare times from the same table) then 
`Long.max()` could be used after checking the time types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to