hkeebler commented on a change in pull request #1344: Fix #1043 Support stable ~del split points URL: https://github.com/apache/accumulo/pull/1344#discussion_r323917658
########## File path: test/src/main/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java ########## @@ -186,7 +187,8 @@ public void dontGCRootLog() throws Exception { } private Mutation createDelMutation(String path, String cf, String cq, String val) { - Text row = new Text(MetadataSchema.DeletesSection.getRowPrefix() + path); + Text row = + new Text(MetadataSchema.DeletesSection.getRowPrefix() + SortSkew.getCode(path) + path); Review comment: The problem here is where to put something like this. the idea was to keep the implementation of the skew code known just to Ample. I also wanted to make it available to use with bulkimports if desired. Maybe it should be a subclass of MetadataSchema and the encode /decode belong there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services