keith-turner commented on a change in pull request #1366: Fix #1365 2.1 Upgrade
processing for #1043 ~del
URL: https://github.com/apache/accumulo/pull/1366#discussion_r326717136
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/upgrade/Upgrader9to10.java
##########
@@ -352,4 +372,87 @@ MetadataTime computeRootTabletTime(ServerContext context,
Collection<String> goo
}
}
+ static public void upgradeFileDeletes(ServerContext ctx, Ample.DataLevel
level) {
+
+ String tableName = level.metaTable();
+ AccumuloClient c = ctx;
+
+ // find all deletes
+ try (BatchWriter writer = c.createBatchWriter(tableName, new
BatchWriterConfig())) {
+ String continuePoint = "";
+ boolean stillDeletes = true;
+
+ while (stillDeletes) {
+ List<String> deletes = new ArrayList<>();
+ log.info("looking for candidates");
+ stillDeletes = getOldCandidates(ctx, tableName, continuePoint,
deletes);
+ log.info("found {} deletes to upgrade", deletes.size());
+ for (String olddelete : deletes) {
+ // create new formatted delete
+ writer.addMutation(upgradeDeleteMutation(olddelete));
+ }
+ writer.flush();
+
+ // if nothing thrown then we're good so mark all deleted
+ for (String olddelete : deletes) {
+ writer.addMutation(deleteOldDeleteMutation(olddelete));
+ }
+ writer.flush();
+
+ // give it some time for memory to clean itself up if needed
+ sleepUninterruptibly(5, TimeUnit.SECONDS);
+ continuePoint = deletes.get(deletes.size() - 1);
+ log.debug("continuing from {}", continuePoint);
+ }
+ } catch (Exception e) {
+ ;
Review comment:
this is not good... could do `throw RuntimeException(e)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
