keith-turner commented on a change in pull request #1405: Made tablet
assignment wait on upgrade.
URL: https://github.com/apache/accumulo/pull/1405#discussion_r342275009
##########
File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
##########
@@ -268,7 +269,14 @@ synchronized void setMasterState(MasterState newState) {
}
}
- private UpgradeCoordinator upgradeCoordinator;
+ private volatile UpgradeCoordinator upgradeCoordinator;
+
+ private UpgradeStatus getUpgradeStatus() {
+ if (upgradeCoordinator == null)
+ return UpgradeStatus.INITIAL;
+ return upgradeCoordinator.getStatus();
+ }
+
Review comment:
That was a good idea. That refactoring lead to some other slight
refactorings and I like how the whole thing turned out. Made the changes in
d31fc6bf0a8b8887af735e26f6c4f9257af12eb9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services