milleruntime commented on a change in pull request #1411: Move system iterators
to iteratorsImpl package. Closes #1390
URL: https://github.com/apache/accumulo/pull/1411#discussion_r343351819
##########
File path:
core/src/main/java/org/apache/accumulo/core/iterators/SortedMapIterator.java
##########
@@ -39,7 +40,7 @@
* columnFamilies passed into seek(). If you want a Map-backed Iterator that
returns only sought
* CFs, construct a new ColumnFamilySkippingIterator(new
SortedMapIterator(map)).
*
- * @see org.apache.accumulo.core.iterators.system.ColumnFamilySkippingIterator
+ * @see ColumnFamilySkippingIterator
*/
public class SortedMapIterator implements InterruptibleIterator {
Review comment:
I am little concerned about the all the casting we do with
InterrubitleIterator. Here is an example:
https://github.com/apache/accumulo/blob/61b2b9ebfc815054b1b8281ff485b993823aa4a5/core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/SourceSwitchingIterator.java#L263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
