keith-turner commented on a change in pull request #1413: add choosable() to 
VolumeChooser and VolumeManager interfaces.
URL: https://github.com/apache/accumulo/pull/1413#discussion_r343689591
 
 

 ##########
 File path: 
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java
 ##########
 @@ -44,6 +44,20 @@
    */
   String choose(VolumeChooserEnvironment env, String[] options) throws 
VolumeChooserException;
 
+  /**
+   * Return all volumes from options that are appropriate for the given 
environment.
 
 Review comment:
   ```suggestion
      * Return the subset of volume options that could possibly be chosen by 
this chooser.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to