ctubbsii commented on a change in pull request #1412: Stopped calling
getBytes() on strings passed to Value
URL: https://github.com/apache/accumulo/pull/1412#discussion_r343927054
##########
File path: core/src/test/java/org/apache/accumulo/core/data/ValueTest.java
##########
@@ -194,7 +194,7 @@ public void testEquals() {
@Test
public void testString() {
Value v1 = new Value("abc");
- Value v2 = new Value("abc".getBytes(UTF_8));
+ Value v2 = new Value("abc");
Review comment:
This one shouldn't be changed, because it's explicitly testing the
`CharSequence` and `byte[]` equivalence.
```suggestion
Value v2 = new Value("abc".getBytes(UTF_8));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
