billierinaldi commented on a change in pull request #1450: Fix #1373 Support
the init scope in some VolumeChoosers
URL: https://github.com/apache/accumulo/pull/1450#discussion_r355595049
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##########
@@ -362,7 +361,7 @@ private boolean initialize(SiteConfiguration siteConfig,
Configuration hadoopCon
UUID uuid = UUID.randomUUID();
// the actual disk locations of the root table and tablets
String[] configuredVolumes = VolumeConfiguration.getVolumeUris(siteConfig,
hadoopConf);
- VolumeChooserEnvironment chooserEnv = new
VolumeChooserEnvironmentImpl(ChooserScope.INIT, null);
+ VolumeChooserEnvironment chooserEnv = new
InitVolumeChooserEnvironmentImpl(siteConfig);
Review comment:
Thanks for the review, @keith-turner! If we end up implementing an
InitServerContext as per Christopher's suggestion, then I think we won't need
to introduce an InitVolumeChooserEnvironmentImpl. In that case, do you think we
should improve the VolumeChooserEnvironmentImpl to have a table ID and endRow
for the INIT scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
