EdColeman commented on a change in pull request #1528: Switch to Log4j2
URL: https://github.com/apache/accumulo/pull/1528#discussion_r384029781
##########
File path: pom.xml
##########
@@ -235,6 +235,11 @@
<artifactId>protobuf-java</artifactId>
<version>3.7.1</version>
</dependency>
+ <dependency>
+ <groupId>com.lmax</groupId>
+ <artifactId>disruptor</artifactId>
+ <version>3.4.2</version>
+ </dependency>
Review comment:
The LMAX disrupter is basically a ring buffer that is designed to minimize
locking and from most reports significantly improves performance. We should use
it if at all possible. Enabling it and keeping the dependency seems to make it
easier on users and should help to encourage its usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
