phrocker commented on a change in pull request #1527: Added detailed trace logging for FATE #1316 URL: https://github.com/apache/accumulo/pull/1527#discussion_r384558361
########## File path: core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.accumulo.core.logging; + +import static org.apache.accumulo.fate.FateTxId.formatTid; + +import java.io.Serializable; +import java.util.EnumSet; +import java.util.List; +import java.util.function.Function; + +import org.apache.accumulo.fate.ReadOnlyRepo; +import org.apache.accumulo.fate.Repo; +import org.apache.accumulo.fate.StackOverflowException; +import org.apache.accumulo.fate.TStore; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class FateLogger { + private static final String PREFIX = Logging.PREFIX + "fate."; + + // Logs all mutations to FATEs persistent storage. Enabling this logger could help debug + // reproducible problems with FATE transactions. + private static final Logger storeLog = LoggerFactory.getLogger(PREFIX + "store"); + + public static <T> TStore<T> wrap(TStore<T> store, Function<Repo<T>,String> toLogString) { + + // only logging operations that change the persisted data, not operations that only read data + return new TStore<T>() { + + @Override + public long reserve() { + return store.reserve(); + } + + @Override + public void reserve(long tid) { + store.reserve(tid); + } + + @Override + public void unreserve(long tid, long deferTime) { + store.unreserve(tid, deferTime); + } + + @Override + public List<ReadOnlyRepo<T>> getStack(long tid) { + return store.getStack(tid); + } + + @Override + public TStatus getStatus(long tid) { + return store.getStatus(tid); + } + + @Override + public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) { + return store.waitForStatusChange(tid, expected); + } + + @Override + public Serializable getProperty(long tid, String prop) { + return store.getProperty(tid, prop); + } + + @Override + public List<Long> list() { + return store.list(); + } + + @Override + public long create() { + long tid = store.create(); + if (storeLog.isTraceEnabled()) + storeLog.trace("created {}", formatTid(tid)); + return tid; + } + + @Override + public Repo<T> top(long tid) { + return store.top(tid); + } + + @Override + public void push(long tid, Repo<T> repo) throws StackOverflowException { + store.push(tid, repo); + storeLog.trace("pushed {} {}", formatTid(tid), toLogString.apply(repo)); Review comment: Why is this one not wrapped? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
