milleruntime commented on issue #1549: Fixes #1542 - Created a randomIndex member of ThriftTransportPool URL: https://github.com/apache/accumulo/pull/1549#issuecomment-595406345 Thanks for looking at this test. While this might help with the randomness of the ThriftTransportPool, I am usually against adding logic to change the behavior of a class specifically for a test. I think the code [here](https://github.com/apache/accumulo/pull/1241/files#diff-a8fae6237f477626112730e174b19a78R144-R166) should be removed as I am not sure it is testing what it was intended to. I will defer to @keith-turner since he worked on that change. Also, I think this test should check to make sure the server list has both tservers in it before proceeding. Currently it will just grab the first tserver it sees in ZK, breaking out of the ```servers.isEmpty()``` loop before seeing the second one.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
