milleruntime commented on a change in pull request #1553: Simplify some 
VolumeManager tooling
URL: https://github.com/apache/accumulo/pull/1553#discussion_r389850201
 
 

 ##########
 File path: 
server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java
 ##########
 @@ -71,6 +70,10 @@
   static final Text cq = new Text("cq");
   static final Value value = new Value("value");
 
+  @Rule
+  public TemporaryFolder tempFolder =
+      new TemporaryFolder(new File(System.getProperty("user.dir") + 
"/target"));
 
 Review comment:
   This is cool.  Won't this delete the entire target directory though? If that 
is the case then I would imagine this would interfere with the build. Or is it 
anything that is created under this test that gets removed?  It is not clear 
from the javadoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to