arvindshmicrosoft commented on a change in pull request #1555: Fix idempotency
bug in importtable
URL: https://github.com/apache/accumulo/pull/1555#discussion_r390054896
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/tableOps/MoveExportedFiles.java
##########
@@ -48,17 +49,22 @@
Map<String,String> fileNameMappings =
PopulateMetadataTable.readMappingFile(fs, tableInfo);
+ FileStatus[] exportedFiles = fs.listStatus(new
Path(tableInfo.exportDir));
+ FileStatus[] importedFiles = fs.listStatus(new
Path(tableInfo.importDir));
+
Review comment:
This seems quite elegant, and I am working toward this. The only question I
have at this stage is the usage of the Guava Sets class. I presume there are no
concerns (both for this PR and from later porting this to 2.x) on using Sets
here? I did try using CollectionUtils but it seems far easier to perform set
operations with the Sets class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
