drewfarris commented on issue #1537: Add PrintInfo options to dump full keys, apply formatter URL: https://github.com/apache/accumulo/pull/1537#issuecomment-597074575 > Would be nice to fail with an error message if --fullKeys and --formatter are specified. done. The wording is a little weird because both --fullKeys and --dump are mutually exclusive with --formater, but hopefully you'll agree this is sufficient as it. > If you assign the unchecked code to a variable, you can add this suppression on just that assignment, so it doesn't mask other (fixable, avoidable) problems in the method. done. I'd wanted to do this, but hadn't figured out the variable assignment bit, thanks. > we should probably hard-fail by letting this exception fall through, rather than returning null and by effetively wasting time dumping a file in a format the user doesn't want. done, also removed the null check as it was unnecessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
