ctubbsii commented on a change in pull request #1555: Fix idempotency bug in
importtable
URL: https://github.com/apache/accumulo/pull/1555#discussion_r390649146
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/tableOps/MoveExportedFiles.java
##########
@@ -48,17 +49,22 @@
Map<String,String> fileNameMappings =
PopulateMetadataTable.readMappingFile(fs, tableInfo);
+ FileStatus[] exportedFiles = fs.listStatus(new
Path(tableInfo.exportDir));
+ FileStatus[] importedFiles = fs.listStatus(new
Path(tableInfo.importDir));
+
Review comment:
guava-beta-checker requires errorprone. I'm not sold on the idea of
dictating the compiler in the build, especially not for the default build. The
spotbugs plugin would be less invasive (not sure that's the right word I mean).
In any case, that can be a separate issue, if it matters.
I'm going to make one more pass with some comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
