ctubbsii commented on a change in pull request #1558: Resolve relative delete
markers on upgrade. Closes #1463
URL: https://github.com/apache/accumulo/pull/1558#discussion_r391970913
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/upgrade/Upgrader9to10.java
##########
@@ -625,4 +630,30 @@ private static Path resolveRelativePath(String
metadataEntry, Key key) {
return new Path(prefix + tableId.canonical() + metadataEntry);
}
}
+
+ /**
+ * Resolve old relative delete markers of the form /tableId/tabletDir/[file]
to
+ * UpgradeVolume/tables/tableId/tabletDir/[file]
+ */
+ static Path resolveRelativeDelete(String oldDelete, String upgradeProperty) {
+ Path pathNoVolume = VolumeManager.FileType.TABLE.removeVolume(new
Path(oldDelete));
+
+ // removeVolume will return null if path doesn't have a volume aka is a
relative path
Review comment:
I'm still a bit concerned about the wording of this comment here. Is this an
`if` or an `iff (if and only if)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
