milleruntime commented on a change in pull request #1569: Fixes #1464 -
SimpleThreadPool for importtable
URL: https://github.com/apache/accumulo/pull/1569#discussion_r397204780
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -251,6 +251,9 @@
MASTER_BULK_RENAME_THREADS("master.bulk.rename.threadpool.size", "20",
PropertyType.COUNT,
"The number of threads to use when moving user files to bulk ingest "
+ "directories under accumulo control"),
+
MASTER_IMPORTTABLE_RENAME_THREADS("master.importtable.rename.threadpool.size",
"20",
+ PropertyType.COUNT,
+ "The number of threads to use when renaming user files when importing a
table."),
Review comment:
I was thinking deprecate ```master.bulk.rename.threadpool.size``` and create
something more generic like ```master.rename.threadpool.size``` that could be
used anywhere in the Master where we want to optimize renames. Just doing a
quick search for "fs.rename" the new and old Bulk imports could use this
property as well. My point is I don't think it need to have a property for
each fate operation. If a user is having issues with NN renames, they would
benefit in the other operations as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
