ctubbsii edited a comment on issue #1445: add erasure coding and storage policy to table/namespace settings URL: https://github.com/apache/accumulo/pull/1445#issuecomment-603506903 > @ctubbsii Sorry...yes, I was trying to stave off the bit rot that was setting in relative to master. What is the preferred mechanism to keep a PR up-to-date, or is that not desired? It's not a problem. If it's not likely to cause a merge conflict, it's okay if the merge-base is stale. If it's likely to cause a problem (as you identify it was and I take your word for it), either a rebase and force push or merging the master branch onto this branch are both acceptable options. I think it might be preferred to do the latter, because it can be easier to see what changed from the previous reviews. Merging master onto the working branch might have fewer side-effects if we squash the PR once it is accepted (and we usually do). I wasn't necessarily saying you did something wrong... just trying to communicate the consequences for reviewers, in case you weren't already aware (because some contributors aren't... and I don't know who benefits from the advice and who doesn't). As long as you are aware of the consequences, I'll trust you to act on your own best judgement. :smiley_cat:
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
