milleruntime commented on a change in pull request #1572: Refactor use of
ServerConfigurationFactory
URL: https://github.com/apache/accumulo/pull/1572#discussion_r399454328
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/tabletserver/LargestFirstMemoryManager.java
##########
@@ -121,18 +122,16 @@ public void remove(Long key) {
}
}
- LargestFirstMemoryManager(long maxMemory, int maxConcurrentMincs, int
numWaitingMultiplier) {
- this();
- this.maxMemory = maxMemory;
- this.maxConcurrentMincs = maxConcurrentMincs;
- this.numWaitingMultiplier = numWaitingMultiplier;
+ @Override
+ public void init(ServerConfiguration conf) {
+ throw new IllegalStateException("Deprecated method, no longer should be
used.");
Review comment:
I made the change in 1824acd but I made the new method not have a default
impl. My thinking was that since we won't have a way to make them backward
compatible, it would be better to error during compilation than runtime in the
tserver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
