drewfarris commented on a change in pull request #1060: Closes #1053 add 
multi-volume support to import table command.
URL: https://github.com/apache/accumulo/pull/1060#discussion_r404055502
 
 

 ##########
 File path: test/pom.xml
 ##########
 @@ -212,6 +212,7 @@
           <configuration>
             
<testSourceDirectory>${project.basedir}/src/main/java/</testSourceDirectory>
             
<testClassesDirectory>${project.build.directory}/classes/</testClassesDirectory>
+            <skipTests>${failsafe.skip}</skipTests>
 
 Review comment:
   @ctubbsii - the reason for adding separate `failsafe.skip` and 
`surefire.skip` properties was so that surefire tests could be skipped but 
failsafe tests would still be run. `-DskipITs` allows you to run  surefire 
(unit) tests without failsafe (integration) tests while `-DskipTests` skips 
both surefire and failsafe test. I'll remove these for now to get this merged, 
but we might want to consider doing something like this in the future?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to