ctubbsii commented on a change in pull request #1583: Added VSCode resources to .gitignore and apache-rat excludes (#1582) URL: https://github.com/apache/accumulo/pull/1583#discussion_r405927819
########## File path: .gitignore ########## @@ -26,3 +26,5 @@ /nbproject/ /nbactions.xml /nb-configuration.xml +.vscode/ +.factorypath Review comment: Do these exist only at the root of the project, or do they exist throughout the project? If only at the root, they should be: ```suggestion /.vscode/ /.factorypath ``` (I assume `.factorypath` is a regular file; if it's a directory, it should end in a slash also.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
