andrewglowacki commented on issue #1584: Moved ThriftClientHandler out of TabletServer for #1581 URL: https://github.com/apache/accumulo/pull/1584#issuecomment-612973225 @keith-turner I see, great! No problem, I don't mind pointing things out. I'll do anything to make it easier to review, especially since it's such a big change. Unfortunately there's quite a few changes, however virtually all of them are either: - prepending variables that were owned by TabletServer with 'server.' such as: `sessionManager.unreserveSession(scanSession);` to: `server.sessionManager.unreserveSession(scanSession);` - prepending methods that were owned by TabletServer with 'server.' such as: `long totalQueued = updateTotalQueuedMutationSize(additionalMutationSize);` to: `long totalQueued = server.updateTotalQueuedMutationSize(additionalMutationSize);` - changing private variables to package-private in TabletServer.java such as: `private final TabletServerResourceManager resourceManager;` to: `final TabletServerResourceManager resourceManager;` In addition to making these types of changes to ThriftClientHandler, they were also necessary in AssignmentHandler and UnloadTabletHandler for the same reasons.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
