volmasoft commented on issue #21:
URL: https://github.com/apache/accumulo-proxy/issues/21#issuecomment-621283417
I think there's two ways 1 that goes towards Accumulo's approach, 1 that
goes towards Nifi's approach.
### 1. accumulo-docker approach
Take the variables straight off the command line e.g.:
```
ACCUMULO_CL_OPTS="-o instance.name=uno -o
instance.zookeepers=my.host.com:2181"
docker run accumulo-proxy:latest ${ACCUMULO_CL_OPTS}
```
### 2. Hybrid approach
Provide a single environment variable e.g. similar to how accumulo-docker
sets ACCUMULO_CL_OPTS
```
ACCUMULO_CL_OPTS="-o instance.name=uno -o
instance.zookeepers=my.host.com:2181"
docker run -e EXTRA_PROPS=${ACCUMULO_CL_OPTS} accumulo-proxy:latest
```
Then inside our code we grab the PROPS environment variable and override any
that are specified in proxy.properties.
### 3. NiFi's approach
Provide individual environments variables for each property e.g. like NiFi
does here: https://hub.docker.com/r/apache/nifi/
So something like
```
docker run -e INSTANCE_NAME="uno" -e INSTANCE_ZOOKEEPERS="my.host.com:2181"
accumulo-proxy:latest
```
We would have to decide an approach to load these properties either in
proxy-env or in the Java code.
---
Personally I find the NiFi approach to be a cleaner approach especially if
we look towards providing anything like a docker-compose or Kubernetes example
configurations in the future.
Whichever approach we take we should be consistent so I think we'd have to
dive into accumulo-docker and update it if we take a different approach,
perhaps before we release the first container image on dockerhub.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
