EdColeman commented on a change in pull request #1605: URL: https://github.com/apache/accumulo/pull/1605#discussion_r424685598
########## File path: core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionConfigurer.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.client.admin.compaction; + +import java.util.Collection; +import java.util.Map; + +import org.apache.accumulo.core.client.PluginEnvironment; +import org.apache.accumulo.core.data.TableId; + +/** + * Enables dynamically overriding of per table properties used to create the output file for a + * compaction. For example it could override the per table property for compression. + * + * @since 2.1.0 + */ +public interface CompactionConfigurer { Review comment: Would this be more appropriately named as a factory? It seems to be creating a compaction configuration - so maybe something like CompressionConfigFactory? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
