keith-turner commented on a change in pull request #1622:
URL: https://github.com/apache/accumulo/pull/1622#discussion_r435512348
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -452,6 +458,9 @@
"The time to wait for a tablet server to process a bulk import
request."),
TSERV_MINTHREADS("tserver.server.threads.minimum", "20", PropertyType.COUNT,
"The minimum number of threads to use to handle incoming requests."),
+ TSERV_MINTHREADS_ALLOW_TIMEOUT("tserver.server.thread.timeout.allowed",
"true",
Review comment:
I am slightly in favor of false because it addresses a known problem and
seems like it should not cause problems, but it could. The way this change is
structured it does not change all of the existing code to false just a few
select places, which is good. Leaving most of the internal usage w/ a hard
coded true is good and changing just these configurable ones to false may be a
good way to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
