keith-turner commented on a change in pull request #1605:
URL: https://github.com/apache/accumulo/pull/1605#discussion_r441914459
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/CompactionConfig.java
##########
@@ -21,25 +21,37 @@
import static java.util.Objects.requireNonNull;
import static
org.apache.accumulo.core.clientImpl.CompactionStrategyConfigUtil.DEFAULT_STRATEGY;
-import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
+import java.util.Map;
+import java.util.function.BooleanSupplier;
import org.apache.accumulo.core.client.IteratorSetting;
+import org.apache.accumulo.core.client.admin.compaction.CompactionConfigurer;
+import org.apache.accumulo.core.client.admin.compaction.CompactionSelector;
+import org.apache.accumulo.core.clientImpl.CompactionStrategyConfigUtil;
+import org.apache.accumulo.core.clientImpl.UserCompactionUtils;
import org.apache.hadoop.io.Text;
+import com.google.common.base.Preconditions;
+
/**
* This class exist to pass parameters to {@link
TableOperations#compact(String, CompactionConfig)}
*
* @since 1.7.0
*/
public class CompactionConfig {
+
private Text start = null;
private Text end = null;
private boolean flush = true;
private boolean wait = true;
private List<IteratorSetting> iterators = Collections.emptyList();
+ @SuppressWarnings("removal")
private CompactionStrategyConfig compactionStrategy = DEFAULT_STRATEGY;
+ private Map<String,String> hints = Map.of();
+ private PluginConfig selectorConfig = UserCompactionUtils.DEFAULT_CSC;
Review comment:
done in 5aa9672
##########
File path:
core/src/main/java/org/apache/accumulo/core/spi/compaction/CompactionServices.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.spi.compaction;
+
+import java.util.Set;
+
+/**
+ * @since 2.1.0
+ */
+public interface CompactionServices {
Review comment:
done in 5aa9672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
