milleruntime commented on a change in pull request #1646:
URL: https://github.com/apache/accumulo/pull/1646#discussion_r448573588



##########
File path: 
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -148,6 +149,13 @@ public CompactionStats call() {
           reportedProblem = true;
         } catch (CompactionCanceledException e) {
           throw new IllegalStateException(e);
+        } catch (Throwable t) {

Review comment:
       > Maybe a follow on issue would be best. I feel like this is a wider 
issue, because any thread could encounter an error and having a single 
mechanism for handling unexpected errors in server processes seems useful.
   
   I agree.  I think since its clear that we need to retry flushes on the 
NoClassDefFoundError that should be fixed here, with anything further being 
follow on work.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to