ivakegg commented on a change in pull request #1646:
URL: https://github.com/apache/accumulo/pull/1646#discussion_r448580683



##########
File path: 
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -148,6 +149,13 @@ public CompactionStats call() {
           reportedProblem = true;
         } catch (CompactionCanceledException e) {
           throw new IllegalStateException(e);
+        } catch (Throwable t) {

Review comment:
       Thank you for your observations.  I will take out all of the retry stuff 
and simply handle the condition that this ticket warrants.  A more general and 
generic way of handling critical thread failures is needed if we want.  This 
one was kind of weird given the TabletMemory holds onto the memory being 
compacted at the same time a new memory block is used ongoing mutations so 
there are multiple states to handle at the same time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to