ctubbsii commented on a change in pull request #1688:
URL: https://github.com/apache/accumulo/pull/1688#discussion_r474187125
##########
File path:
server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
##########
@@ -104,28 +105,27 @@ public void run() {
Span findWalsSpan = Trace.start("findReferencedWals");
HashSet<String> closed = null;
try {
- sw.start();
+ startTime = System.nanoTime();
closed = getClosedLogs(conn);
+ duration = Duration.ofNanos(System.nanoTime() - startTime);
} finally {
- sw.stop();
findWalsSpan.stop();
}
- log.info("Found " + closed.size() + " WALs referenced in metadata in " +
sw.toString());
- sw.reset();
+ log.info("Found " + closed.size() + " WALs referenced in metadata in " +
duration);
Review comment:
I tried really hard to preserve the format, without writing or copying
code, and still supporting the various Guava versions, which had breaking
changes in Stopwatch, and finally gave up. I don't think the format matters as
much as the information... and I'm not sure the information even matters that
much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
