jkosh44 commented on pull request #1701: URL: https://github.com/apache/accumulo/pull/1701#issuecomment-687922256
> Overall, this looks good to me. I made some suggestions for improvements, and I think this could use a unit test, but otherwise, looks okay. > > Are you able to include a unit test for this? @ctubbsii I've made the changes you suggested (and I'm adding a unit test now). One scenario I was thinking about is if the provided prefix is a subset of a recognized prefix. For example, let's say we are given the prefix "a.b.c" and "a.b" is a recognized prefix. Then it may be more efficient to check for this scenario and only iterate through "a.b"'s properties instead of iterating through all the properties. What do you think (if that made sense)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
