milleruntime commented on a change in pull request #1762:
URL: https://github.com/apache/accumulo/pull/1762#discussion_r516068685
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java
##########
@@ -144,6 +144,13 @@ default void putGcCandidates(TableId tableId,
Collection<StoredTabletFile> candi
throw new UnsupportedOperationException();
}
+ /**
+ * Unlike {@link #putGcCandidates(TableId, Collection)} this takes file and
dir GC candidates.
+ */
+ default void putGcFdCandidates(TableId tableId, Collection<String>
candidates) {
+ throw new UnsupportedOperationException();
+ }
+
Review comment:
What is "Fd" short for? Should comment what the "Fd" in the method name
means.
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java
##########
@@ -144,6 +144,13 @@ default void putGcCandidates(TableId tableId,
Collection<StoredTabletFile> candi
throw new UnsupportedOperationException();
}
+ /**
+ * Unlike {@link #putGcCandidates(TableId, Collection)} this takes file and
dir GC candidates.
+ */
+ default void putGcFdCandidates(TableId tableId, Collection<String>
candidates) {
+ throw new UnsupportedOperationException();
+ }
+
Review comment:
If "Fd" means "file and Directories" you could just put that explicitly
in the name like `putGcFileCandidates` or `putGcFileDirectories`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
