EdColeman commented on pull request #1787: URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729877505
I was researching the PR and assessing the impact that Christopher pointed out - he just types faster. I am also concerned with breaking existing installations and would need to see either an upgrade path or have it implemented as an option. I tried to point out that we have a couple of communication channels available where we could work this out while encouraging additional contributions. I did not want to see Szabolcs become frustrated if the PR was not immediately accepted - the code and the contribution are welcome, but there are additional considerations that may not be obvious at the start. If there had been an issue / question raised first, or if there was a dialog, via email or slack, then maybe those could have worked out. Taking the time and effort to create a code change is welcome, but engaging with the community first might alter the approach, make the change easier to integrate and would help ensure that everyone's interest and concerns are also addressed. The intent of the PR is valid and I'm assuming being driven by a requirement, but there also is an obligation to the existing user base. I would not expect the community to accept allowing a change that broke existing installations on an upgrade without providing some path forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
