ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732422732


   > No the current code fetches current and future if you specify 
`ColumnType.LOCATION` as one of the columns to fetch. Instead of adding a new 
one for suspend and then requiring you to specify 3 different enums to fetch, I 
made it so `LOCATION` will fetch all 4.
   
   Okay. I was confused. I see where you are adding it to the fetched columns 
list when this enum is set.
   
   That said, because this would make all 4 columns fetched every time we want 
to fetch the CURRENT or FUTURE location, it might be better to leave LAST and 
create a new SUSPEND enum, so that way we only need to fetch the specific 
locations we need, and no more. It's a little weird that the LOCATION enum 
fetches both CURRENT and FUTURE locations, but only one should be set anyway, 
so it's probably fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to