ctubbsii opened a new issue #1808:
URL: https://github.com/apache/accumulo/issues/1808
**Describe the bug**
LoggingRunnable catches Throwable. This is very bad. I saw a compaction
thread die due to OutOfMemoryError, and LoggingRunnable logged it, and the
tserver kept on running... in a very bad state.
I get that maybe we want a best effort attempt to log when there's a problem
in a LoggingRunnable thread... but we should still propagate the Throwable,
*especially* if it's an Error type! The tserver (or any other server) can't be
trusted to make good decisions after these kinds of problems occur and are
ignored by the running system. We should let these be handled by the uncaught
exception handler after logging by re-throwing them.
**Versions (OS, Maven, Java, and others, as appropriate):**
- Affected version(s) of this project: 2.1.0-SNAPSHOT (but probably affects
1.x also)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]