ctubbsii commented on a change in pull request #1813:
URL: https://github.com/apache/accumulo/pull/1813#discussion_r532893967
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
##########
@@ -52,17 +52,10 @@
public class ChaoticLoadBalancer extends TabletBalancer {
private static final Logger log =
LoggerFactory.getLogger(ChaoticLoadBalancer.class);
- @SuppressWarnings("unused")
- private final String tableName;
-
- public ChaoticLoadBalancer() {
- this.tableName = null;
- }
+ public ChaoticLoadBalancer() {}
// Required constructor
- public ChaoticLoadBalancer(String tableName) {
- this.tableName = tableName;
- }
+ public ChaoticLoadBalancer(String tableName) {}
Review comment:
We dynamically load balancer classes, based on user configuration. My
guess is that this supports per-table balancing features. I left it as-is,
rather than head down the rabbit hole of figuring out if it was necessary.
:smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
