milleruntime commented on pull request #1828: URL: https://github.com/apache/accumulo/pull/1828#issuecomment-740797724
> > Why not make the methods throw the exception themselves? It looks like they are already throwing `ThriftSecurityException`. > > 1. That would be a bigger change, > > 2. That would be inconsistent with how the methods are used today, and > > 3. In some cases, we don't want to fail yet... as it's one of several conditions which can be satisfied to perform the operation, so the boolean is needed. OK I see that now. For example, the Auditing needs to know the result so it can be logged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
