ctubbsii opened a new pull request #1834: URL: https://github.com/apache/accumulo/pull/1834
This PR contains two small commits: --- Consolidate tablet obscuring code This fixes #1805 Move implementation of tablet obscuring code into KeyExtent and remove duplicate implementations. Also fixup trivial constant in VisMetricsGatherer, so it is private and fix typo in ZKSecurityTool to clarify that the salt length is 8 bytes by default, not the hash length --- Update SystemCredentials to use crypt(3) format This fixes #1810 This updates the SystemToken generation to use SHA-512 while hashing the system's `instance.*` configuration properties (including `instance.secret`) by using commons-codec's crypt(3) implementation. It also adds more javadocs and makes the code a bit more readable, while removing a hard-coded global constant and an unneeded new instance property introduced in #1798. That property is unneeded, since the existence of the property itself creates wire-incompatibility. Instead, this change explicitly bumps the wire version. Also add sanity checks in SystemCredentialsTest for the wire version values and to detect significant changes in the default algorithm used by commons-codec to hash the credentials to prevent suprises when upgrading the commons-codec library in future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
