Manno15 edited a comment on pull request #1832:
URL: https://github.com/apache/accumulo/pull/1832#issuecomment-744617613


   > @Manno15 - are you working adding tests for the other calls? Or would it 
help if someone also took a look?
   
   I am splitting time between this and #1824. I am willing to work on adding 
these other tests but I welcome help if you are offering it. 
   
   > The following RPC calls were affected: initiateFlush, waitForFlush, 
shutdown, shutdownTabletServer, setMasterGoalState, setSystemProperty, and 
removeSystemProperty. Ideally, we should have test coverage for all of these 
cases.
   
   Should they be added to this IT? Similar to how I did `flush` or do you 
think there is a better location for all of these? I am unsure if 
`permissionsIT` is there to test that the permissions work or there to test the 
underlying function that uses the permission. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to