ctubbsii commented on a change in pull request #1834:
URL: https://github.com/apache/accumulo/pull/1834#discussion_r542634295
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/security/SystemCredentials.java
##########
@@ -83,10 +82,19 @@ public TCredentials toThrift(String instanceID) {
public static final class SystemToken extends PasswordToken {
/**
- * Accumulo servers will only communicate with each other when this is the
same. Bumped for 2.0
- * to prevent 1.9 and 2.0 servers from communicating.
+ * Accumulo servers will only communicate with each other when this is the
same.
+ *
+ * <ul>
+ * <li>Initial version 2 for 1.5 to support rolling upgrades for bugfix
releases (ACCUMULO-751)
+ * <li>Bumped to 3 for 1.6 for additional namespace RPC changes
(ACCUMULO-802)
+ * <li>Bumped to 4 for 2.0 to prevent 1.9 and 2.0 servers from
communicating (#1139)
+ * <li>Bumped to 5 for 2.1 because of system credential hash
incompatibility (#1798 / #1810)
+ * </ul>
*/
- private static final Integer INTERNAL_WIRE_VERSION = 4;
+ static final int INTERNAL_WIRE_VERSION = 5;
+
+ static final String SALT_PREFIX = "$6$"; // SHA-512
Review comment:
This is the well-known scheme for crypt(3) formatted strings. I think
it's self-explanatory, since we're specifically using it with the Crypt API
(which has good javadocs) and because crypt(3) is well-known. See the man page
at https://www.man7.org/linux/man-pages/man3/crypt.3.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
