milleruntime commented on a change in pull request #1842:
URL: https://github.com/apache/accumulo/pull/1842#discussion_r546235302
##########
File path:
test/src/main/java/org/apache/accumulo/harness/MiniClusterHarness.java
##########
@@ -57,78 +58,18 @@
public class MiniClusterHarness {
private static final Logger log =
LoggerFactory.getLogger(MiniClusterHarness.class);
- private static final AtomicLong COUNTER = new AtomicLong(0);
-
private static final String PROP_PREFIX =
"org.apache.accumulo.test.functional.";
public static final String USE_SSL_FOR_IT_OPTION = PROP_PREFIX +
"useSslForIT";
public static final String USE_CRED_PROVIDER_FOR_IT_OPTION = PROP_PREFIX +
"useCredProviderForIT";
public static final String USE_KERBEROS_FOR_IT_OPTION = PROP_PREFIX +
"useKrbForIT";
public static final String TRUE = Boolean.toString(true);
- // TODO These are defined in MiniKdc >= 2.6.0. Can be removed when minimum
Hadoop dependency is
- // increased to that.
- public static final String JAVA_SECURITY_KRB5_CONF =
"java.security.krb5.conf",
- SUN_SECURITY_KRB5_DEBUG = "sun.security.krb5.debug";
-
- /**
- * Create a MiniAccumuloCluster using the given Token as the credentials for
the root user.
- */
- public MiniAccumuloClusterImpl create(AuthenticationToken token) throws
Exception {
- return create(MiniClusterHarness.class.getName(),
Long.toString(COUNTER.incrementAndGet()),
- token);
- }
-
- public MiniAccumuloClusterImpl create(AuthenticationToken token, TestingKdc
kdc)
- throws Exception {
- return create(MiniClusterHarness.class.getName(),
Long.toString(COUNTER.incrementAndGet()),
- token, kdc);
- }
-
- public MiniAccumuloClusterImpl create(AccumuloITBase testBase,
AuthenticationToken token)
- throws Exception {
- return create(testBase.getClass().getName(),
testBase.testName.getMethodName(), token);
- }
-
- public MiniAccumuloClusterImpl create(AccumuloITBase testBase,
AuthenticationToken token,
- TestingKdc kdc) throws Exception {
- return create(testBase, token, kdc,
MiniClusterConfigurationCallback.NO_CALLBACK);
- }
-
public MiniAccumuloClusterImpl create(AccumuloITBase testBase,
AuthenticationToken token,
TestingKdc kdc, MiniClusterConfigurationCallback configCallback) throws
Exception {
return create(testBase.getClass().getName(),
testBase.testName.getMethodName(), token,
configCallback, kdc);
}
- public MiniAccumuloClusterImpl create(AccumuloClusterHarness testBase,
AuthenticationToken token,
- TestingKdc kdc) throws Exception {
- return create(testBase.getClass().getName(),
testBase.testName.getMethodName(), token, testBase,
- kdc);
- }
-
- public MiniAccumuloClusterImpl create(AccumuloClusterHarness testBase,
AuthenticationToken token,
- MiniClusterConfigurationCallback callback) throws Exception {
- return create(testBase.getClass().getName(),
testBase.testName.getMethodName(), token,
- callback);
- }
-
- public MiniAccumuloClusterImpl create(String testClassName, String
testMethodName,
- AuthenticationToken token) throws Exception {
- return create(testClassName, testMethodName, token,
- MiniClusterConfigurationCallback.NO_CALLBACK);
- }
-
- public MiniAccumuloClusterImpl create(String testClassName, String
testMethodName,
- AuthenticationToken token, TestingKdc kdc) throws Exception {
- return create(testClassName, testMethodName, token,
- MiniClusterConfigurationCallback.NO_CALLBACK, kdc);
- }
-
- public MiniAccumuloClusterImpl create(String testClassName, String
testMethodName,
- AuthenticationToken token, MiniClusterConfigurationCallback
configCallback) throws Exception {
- return create(testClassName, testMethodName, token, configCallback, null);
- }
-
Review comment:
Nice cleanup!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
